Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce verifier KZG params #4

Conversation

davidnevadoc
Copy link

Same as #2, targeting our actual branch...

 - modify `verifier_params` -> `into_verifier_params`
 This function now consumes the Commitment Scheme parameters.
@davidnevadoc davidnevadoc marked this pull request as ready for review April 1, 2024 16:09
Copy link
Collaborator

@iquerejeta iquerejeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

replace IPAParams genration function with manual generation
@davidnevadoc davidnevadoc merged commit c161056 into input-output-hk:fixed_73408a1 Apr 3, 2024
12 checks passed
iquerejeta added a commit that referenced this pull request May 8, 2024
Implement the duplex construction according to the "SAFE" spec
iquerejeta added a commit that referenced this pull request May 8, 2024
…hk/fixes/address-pr-4-comments

Address comments in PR #4
iquerejeta pushed a commit that referenced this pull request May 8, 2024
* add: ParamsVerifierKZG

 - modify `verifier_params` -> `into_verifier_params`
 This function now consumes the Commitment Scheme parameters.

* remove: generators for G1/G2 from VerifierParams

* fix: check parms len

* fix: improve error msg for downsize

* fix: arithmetic bench

replace IPAParams genration function with manual generation

* fix: clippy lints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants